West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 1 | Module-Structuring-and-Testing-Data#1442
Open
burhan-mustafa wants to merge 16 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
burhan-mustafa
added
Needs Review
cjyuan
reviewed
Jul 7, 2026
| // trying to create an age variable and then reassign the value by 1 | ||
|
|
||
| const age = 33; | ||
| var age = 33; |
Contributor
There was a problem hiding this comment.
Should use let instead of var.
Note: Feel free to use AI to find out why use of 'var' is not recommended.
Comment on lines
-23
to
+22
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
|
|
||
| // Answer: The expressions uses the modulo function to work out the remainder value which in this case works out the remaining seconds of the total movie length |
Contributor
There was a problem hiding this comment.
Part (e) has a second question. Could you also answer that?
Contributor
There was a problem hiding this comment.
Note: The file where I left this comment was 2-time-format.js. I just noticed you updated 1-percentage-change.js instead.
cjyuan
added
Reviewed
burhan-mustafa
added
the
Needs Review
cjyuan
reviewed
Jul 9, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you also address this comment: #1442 (comment) ?
Comment on lines
-23
to
+22
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
|
|
||
| // Answer: The expressions uses the modulo function to work out the remainder value which in this case works out the remaining seconds of the total movie length |
Contributor
There was a problem hiding this comment.
You deleted question (e) in your file. The original question is;
// e) What do you think the variable result represents? Can you think of a better name for this variable?
The variable which question (e) refers to is the one named result on line 9:
const result = `${totalHours}:${remainingMinutes}:${remainingSeconds}`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed all tasks in repos solved all tasks in sprint 1